[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12265] Add experiments field to Holdout data model#386
Open
muzahidul-opti wants to merge 2 commits intomasterfrom
Open
[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12265] Add experiments field to Holdout data model#386muzahidul-opti wants to merge 2 commits intomasterfrom
muzahidul-opti wants to merge 2 commits intomasterfrom
Conversation
- Added experiments field to holdout hash with default empty array - Added experiment_holdouts_map to build experiment-to-holdout mappings - Added get_holdouts_for_experiment(experiment_id) method - Added local_holdout?(holdout) helper method - Added comprehensive unit tests covering: * Experiments field parsing and defaults * Experiment-to-holdout mapping functionality * local_holdout? helper method * Backward compatibility with legacy datafiles * Edge cases and multiple holdout scenarios - Ensured backward compatibility (experiments field defaults to empty array) - All 1042 tests pass successfully
Use %w[] syntax for word arrays instead of string arrays Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
get_holdouts_for_experiment(experiment_id)- Returns holdouts targeting a specific experimentlocal_holdout?(holdout)- Returns true if holdout targets specific experimentsTest Coverage
Backward Compatibility
Related
Generated with Claude Code